build: switch submodule to upstream jemalloc and link atomic for musl #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 10, 2025 16:17
Fixes build failures on `*-unknown-linux-musl` targets. Signed-off-by: reigadegr <[email protected]>
…lloc. Signed-off-by: reigadegr <[email protected]>
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Point the jemalloc submodule to the official jemalloc/jemalloc repo instead of the tikv/jemalloc fork.
Always link libatomic when building for *-unknown-linux-musl targets to prevent undefined-reference errors like __atomic_exchange_1.
Details
.gitmodules: updated URL to https://github.com/jemalloc/jemalloc.
jemalloc-sys/build.rs: extend the existing RISC-V check so that libatomic is also linked for musl targets.
No behavioural changes in the resulting allocator.